fix: show overridden props in CLI (#5750)

fixes: #5749 Co-authored-by: Andy Coates <[email protected]>
confluentinc · Jul 3, 2020 · f6fd2ee · f6fd2ee
1 parent 2546794
commit f6fd2ee
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/ksqldb-cli/src/main/java/io/confluent/ksql/cli/console/Console.java b/ksqldb-cli/src/main/java/io/confluent/ksql/cli/console/Console.java
@@ -558,7 +558,7 @@ private void printOverriddenProperties(final QueryDescription queryDescription)
 
     final List<List<String>> rows = overriddenProperties.entrySet().stream()
         .sorted(Entry.comparingByKey())
-        .map(prop -> Arrays.asList(prop.getKey(), "", Objects.toString(prop.getValue())))
+        .map(prop -> Arrays.asList(prop.getKey(), Objects.toString(prop.getValue())))
         .collect(Collectors.toList());
 
     new Builder()

diff --git a/ksqldb-cli/src/test/java/io/confluent/ksql/cli/console/ConsoleTest.java b/ksqldb-cli/src/test/java/io/confluent/ksql/cli/console/ConsoleTest.java
@@ -373,7 +373,7 @@ public void shouldPrintExplainQueryWithError() {
             ImmutableSet.of("sink"),
             "topology",
             "executionPlan",
-            ImmutableMap.of(),
+            ImmutableMap.of("overridden.prop", 42),
             ImmutableMap.of(new KsqlHostInfoEntity("foo", 123), KsqlQueryStatus.ERROR),
             KsqlQueryType.PERSISTENT,
             ImmutableList.of(new QueryError("error", Type.SYSTEM))
@@ -407,7 +407,9 @@ public void shouldPrintExplainQueryWithError() {
           "    \"sinks\" : [ \"sink\" ],\n" +
           "    \"topology\" : \"topology\",\n" +
           "    \"executionPlan\" : \"executionPlan\",\n" +
-          "    \"overriddenProperties\" : { },\n" +
+          "    \"overriddenProperties\" : {\n" +
+          "      \"overridden.prop\" : 42\n" +
+          "    },\n" +
           "    \"ksqlHostQueryStatus\" : {\n" +
           "      \"foo:123\" : \"ERROR\"\n" +
           "    },\n" +
@@ -452,8 +454,16 @@ public void shouldPrintExplainQueryWithError() {
           "------------------- \n" +
           "topology\n" +
           "\n" +
+          "Overridden Properties\n" +
+          "---------------------\n" +
+          " Property        | Value \n" +
+          "-------------------------\n" +
+          " overridden.prop | 42    \n" +
+          "-------------------------\n" +
+          "\n" +
           "Error Details        : error\n" +
-          "Error Type           : SYSTEM\n"));
+          "Error Type           : SYSTEM\n"
+      ));
     }
   }