Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify avro support in docs #1028

Closed
rmoff opened this issue Mar 23, 2018 · 3 comments
Closed

Clarify avro support in docs #1028

rmoff opened this issue Mar 23, 2018 · 3 comments

Comments

@rmoff
Copy link
Member

rmoff commented Mar 23, 2018

On https://github.com/confluentinc/ksql/blob/4.1.x/docs/faq.rst#can-i-use-ksql-with-my-favorite-data-format-e-g-json-avro

  1. so we should be removing “Support for Apache Avro is expected soon.“
  2. add a clear note that support for Avro is for message values only, and that Avro keys are not supported (c.f. Add support for generic message keys (e.g. message keys in Avro or JSON format, STRUCT) #824 )
@miguno
Copy link
Contributor

miguno commented Apr 16, 2018

  1. so we should be removing “Support for Apache Avro is expected soon.“

This has already been fixed since.

  1. add a clear note that support for Avro is for message values only, and that Avro keys are not supported (c.f. Add support for generic message keys (e.g. message keys in Avro or JSON format, STRUCT) #824 )

@joel-hamill : Could you take a look at that? This should be mentioned not just in the FAQ but also in the CREATE STREAM/TABLE related docs, and in the specific Avro/Schema Registry section. Also, we can add the same note about JSON in the CREATE STREAM/TABLE related docs.

@miguno
Copy link
Contributor

miguno commented Apr 16, 2018

Btw, KSQL does have some (limited) support for keys in JSON format, see @rodesai's answer at https://stackoverflow.com/questions/49844380/ksql-kafka-formatting-of-keys.

@joel-hamill
Copy link
Contributor

@rmoff @miguno see #1152

@miguno miguno closed this as completed May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants