Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Queries: templated pre-compiled expected WHERE clauses #3544

Closed
big-andy-coates opened this issue Oct 11, 2019 · 2 comments
Closed

Pull Queries: templated pre-compiled expected WHERE clauses #3544

big-andy-coates opened this issue Oct 11, 2019 · 2 comments
Labels

Comments

@big-andy-coates
Copy link
Contributor

With pull queries we know we require bounds on ROWKEY and, optionally, WINDOWSTART.

Currently we compile such WHERE clauses on each qull query request. It would be nice if we could avoid this cost.

We can precompile these, but we'd need to a way to inject the value, i.e. the 'x' in WHERE ROWKEY='x', which is not currently possible. Alternatively, given we know these are simple expressions, we could just something other than compiled code.

@big-andy-coates big-andy-coates changed the title Pull Queries: Use templated precompiled steps for expected WHERE clauses Pull Queries: templated pre-compiled expected WHERE clauses Oct 11, 2019
@big-andy-coates big-andy-coates mentioned this issue Oct 11, 2019
27 tasks
@big-andy-coates big-andy-coates self-assigned this Oct 11, 2019
@vinothchandar
Copy link
Contributor

@big-andy-coates is this planned in the timeframe for november release? We did a small (unscientific) benchmark which seems to suggest a constant 5ms overhead on these queries.
Would be good to get this done before first release? Came up in a discussion with @derekjn @MichaelDrogalis

@big-andy-coates big-andy-coates removed their assignment Jun 19, 2020
@agavra
Copy link
Contributor

agavra commented Feb 3, 2021

I'm going to close this in favor of the work being done to remove codegen altogether for pull queries see #3497

@agavra agavra closed this as completed Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants