Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull queries: Create unique query ID in StaticQueryExecutor #3854

Closed
vpapavas opened this issue Nov 14, 2019 · 1 comment
Closed

Pull queries: Create unique query ID in StaticQueryExecutor #3854

vpapavas opened this issue Nov 14, 2019 · 1 comment
Assignees

Comments

@vpapavas
Copy link
Member

vpapavas commented Nov 14, 2019

Is your feature request related to a problem? Please describe.
The query ID for pull queries is made static i.e. the same for all pull queries on the same sink. For error logging purposes, this is not informative. At the moment the queryId is returned in the response, so users are able to filter the processing log to get just the errors for their invocation. But if all Pull queries have the same query ID, users cannot pinpoint to the specific query that might have failed.

Background information: This change was made as part of #3708

Describe the solution you'd like
We want to change this back to being a unique ID per pull query.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@big-andy-coates
Copy link
Contributor

Not certain when I did this, but each pull query now has a unique query id, (well, unique enough).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants