Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull queries: Build transformation when building CTAS query #3855

Closed
vpapavas opened this issue Nov 14, 2019 · 0 comments · Fixed by #3910
Closed

Pull queries: Build transformation when building CTAS query #3855

vpapavas opened this issue Nov 14, 2019 · 0 comments · Fixed by #3910
Assignees

Comments

@vpapavas
Copy link
Member

Is your feature request related to a problem? Please describe.
Long term solution to #3708 : Don't build transformations for every pull query on the same state store but rather built them only the first time.

The approach followed by the above PR is to create the transformation only the first time they are requested via the use of a memoized supplier. A longer term solution would be to build the code once, when building the initial CTAS query.

Describe the solution you'd like
Pull the queryId out of the mappers and filters etc, so that it can be passed in as a parameter when being executed. This would allow us to create the baked code as we're building the source aggregate query, i.e. rather than build the materialization, and cache it, on first use, we just build it when building the source aggregate query and store it, rather than the provider, in the query metadata.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants