feat: implements ARRAY_JOIN as requested in (#5028) #5474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@confluentinc It looks like @hpgrahsl just signed our Contributor License Agreement. 👍 Always at your service, clabot |
agavra
reviewed
May 26, 2020
There was a problem hiding this comment.
Overall this looks pretty good! Always happy to see you contributing @hpgrahsl 😂
It is missing what we call "QueryTranslationTests", you can see an example of one in substring.json. After you write this file (you can actually move the more complex tests in ArrayJoinTest.java to this file) you will need to generate the plans that we use to make sure things stay backwards compatible across versions. To do that, simply un-ignore and run PlannedTestGeneratorTest.
ksqldb-engine/src/main/java/io/confluent/ksql/function/udf/array/ArrayJoin.java
Outdated
Show resolved
Hide resolved
ksqldb-engine/src/main/java/io/confluent/ksql/function/udf/array/ArrayJoin.java
Outdated
Show resolved
Hide resolved
ksqldb-engine/src/main/java/io/confluent/ksql/function/udf/array/ArrayJoin.java
Show resolved
Hide resolved
ksqldb-engine/src/main/java/io/confluent/ksql/function/udf/array/ArrayJoin.java
Outdated
Show resolved
Hide resolved
ksqldb-engine/src/test/java/io/confluent/ksql/function/udf/array/ArrayJoinTest.java
Outdated
Show resolved
Hide resolved
ksqldb-engine/src/test/java/io/confluent/ksql/function/udf/array/ArrayJoinTest.java
Show resolved
Hide resolved
I have to look into this and might have further questions most likely about this. I wrote the tests in relation to other, existing array function tests and haven't seen anything like this. |
JimGalasyn
reviewed
May 26, 2020
JimGalasyn
reviewed
May 26, 2020
JimGalasyn
reviewed
May 26, 2020
JimGalasyn
approved these changes
May 26, 2020
hpgrahsl
added a commit
to hpgrahsl/ksql
that referenced
this pull request
Jun 12, 2020
as requested by reviewers: - removed BigInteger from primitive types - added Long and BigDecimal to supported primitive types - dropped support for complex nested types - switched to hamcrest matchers in unit tests - added QueryTranslationTest for via PlannedTestGeneratorTest - adapted docs accordingly
as requested by reviewers: - removed BigInteger from primitive types - added Long and BigDecimal to supported primitive types - dropped support for complex nested types - switched to hamcrest matchers in unit tests - added QueryTranslationTest for via PlannedTestGeneratorTest - adapted docs accordingly
|
as requested by reviewers:
|
stevenpyzhang
pushed a commit
to stevenpyzhang/ksql
that referenced
this pull request
Jun 17, 2020
stevenpyzhang
added a commit
that referenced
this pull request
Jun 17, 2020
Co-authored-by: Hans-Peter Grahsl <[email protected]>
JimGalasyn
added a commit
that referenced
this pull request
Jun 25, 2020
* feat: implements ARRAY_JOIN as requested in (#5028) (#5474) (#5638) Co-authored-by: Hans-Peter Grahsl <[email protected]> * feat: new split_to_map udf (#5563) New UDF split_to_map(input, entryDelimiter, kvDelimiter) to build a map from a string. Useful for taking messages from upstream systems and converting them into a more structured and usable format. * feat: add CHR UDF (#5559) A new UDF, CHR, to turn a number representing a unicode codepoint into a single-character string. Very useful for dealing with non-printable characters (tab, CR, LF, ...) in strings or those characters not easily represented in your local codepage. Co-authored-by: Steven Zhang <[email protected]> Co-authored-by: Hans-Peter Grahsl <[email protected]> Co-authored-by: Nick Dearden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the UDF / scalar function ARRAY_JOIN as requested in (#5028). It creates a flat string representation of all the elements contained in the given array.
Testing done
There are unit tests with several applications of the UDF to verify that it follows the expected behaviour as discussed in the linked issue.