Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a key serde field to records in the Command Topic #846

Closed
rodesai opened this issue Mar 2, 2018 · 2 comments
Closed

Add a key serde field to records in the Command Topic #846

rodesai opened this issue Mar 2, 2018 · 2 comments

Comments

@rodesai
Copy link
Contributor

rodesai commented Mar 2, 2018

We may want to change the serde that KSQL uses to serialize/deserialize Kafka message keys. For example, to fix #724 we could use a binary key format instead of a String with delimiters. To make this possible in the future we should add metadata to the Command Topic about the serde used for keys by the query that executes the command. KSQL should then use that serde if it knows about it, or not run the command if it does not know about that serde.

@apurvam
Copy link
Contributor

apurvam commented Nov 30, 2018

This seems to be a dup of #824 . If so can you close it @rodesai ?

@rodesai
Copy link
Contributor Author

rodesai commented Nov 30, 2018

Yeah, it should get covered as part of the implementation of that feature.

@rodesai rodesai closed this as completed Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants