-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protobuf for V4 - serde to work with v4 of protobuf #3047
Comments
GeneratedMessageV3 is all in the tests. I'm trying to compile it locally, then I can make a patch |
Has anyone looked into this? It's recommended never to use the GeneratedMessageV3 in code. It's all over the testing suite, but I can't get this to complie on my osx machine. I'd be glad to update the code, it should just work if you change the protocol buffer to the latest, 4.26, and use GeneratedMesasage instead of GeneratedMessageV3 |
In my case
Conclusion: Protobuf 4.x version cannot be used in the latest(7.7.0) version of kafka-protobuf. |
You are correct. They have to get rid of the code that references V3 It's slightly more than that right now, I went ahead and changed the references but I got some serialization issues. It's a pretty big update, probably going to take a bit of time for this and gRPC to catch up |
@confluent-alec-kendall @confluent-antonio @confluent-bijinabraham @ConfluentChris |
@venkatduddu I don't even thing grpc has v4 yet - so I doubt you'll see it happen in this plugin before that |
Please note that grpc-java supports protobuf v4, but doesn't yet require it. See discussion at grpc/grpc-java#11015 - they are waiting for more downstream uptake before making that switch and mandating v4. Since grpc-java is already compatible with v4, it is only projects like schema-registry being stuck on v3 that prevent other downstream projects from updating. |
Within the schema registry code for protocol buffers needs to be updated to work with the latest version 4.26
So far I see that GeneratedMessageV3 has been moved to GeneratedMessage. I'm sure there might be many others.
The text was updated successfully, but these errors were encountered: