diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 9a2c1b81d3..cdeecfae54 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -15,3 +15,5 @@ ## Comments ## - If this change is a backward incompatible change, why must this change be made. - Interesting edge cases to note here + +cc @dmlc/gluon-nlp-team diff --git a/CODEOWNERS b/CODEOWNERS index 945c968907..11af321c0e 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -9,4 +9,4 @@ # Global owners -* @dmlc/gluon-nlp-team +* @dmlc/gluon-nlp-committers @dmlc/gluon-nlp-reviewers diff --git a/ci/jenkins/utils.groovy b/ci/jenkins/utils.groovy index b268dac374..ddbde419d5 100644 --- a/ci/jenkins/utils.groovy +++ b/ci/jenkins/utils.groovy @@ -178,7 +178,10 @@ def main_wrapper(args) { err = null try { update_github_commit_status('PENDING', 'Job has been enqueued') - args['core_logic']() + + timestamps { + args['core_logic']() + } // set build status to success at the end currentBuild.result = "SUCCESS" @@ -191,16 +194,18 @@ def main_wrapper(args) { update_github_commit_status('FAILURE', 'Job failed') } } finally { - node { - // Call failure handler - args['failure_handler']() - - // Clean workspace to reduce space requirements - cleanWs() - - // Remember to rethrow so the build is marked as failing - if (err) { - throw err + timestamps { + node { + // Call failure handler + args['failure_handler']() + + // Clean workspace to reduce space requirements + cleanWs() + + // Remember to rethrow so the build is marked as failing + if (err) { + throw err + } } } }