Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added GetSchema in CompiledConstraintSystem #230

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Jan 11, 2022

No description provided.

@gbotrel gbotrel requested a review from ivokub January 11, 2022 23:24
@ivokub
Copy link
Collaborator

ivokub commented Jan 11, 2022

Hmm, I see the changes and they are good, but I do not get the motivation for including Schema as part of CCS. Is it building up for upcoming PR?

@gbotrel
Copy link
Collaborator Author

gbotrel commented Jan 12, 2022

Well, in my mind, I have cases like a Prover / Verifier service, that'll have to potentially unmarshal json witnesses.
This is the case for example in the gnark playground.

We could probably store the schema away from the CCS , and leave it to the developer to handle that. But since schema is likely very cheap to store, I think it simplifies API to put in the CCS.

@gbotrel
Copy link
Collaborator Author

gbotrel commented Jan 12, 2022

(but I did put it in a separate PR because it's up for discussion since there may be better option to do that)

@ivokub
Copy link
Collaborator

ivokub commented Jan 12, 2022

I see, makes sense. But wouldn't SetSchema() allow to create a conflicting state with CCS? It doesn't break CCS if the user sets invalid schema as it isn't used right now (? yet?).
I'll have to think it through a bit to understand more if there are any implications.

@gbotrel
Copy link
Collaborator Author

gbotrel commented Jan 12, 2022

SetSchema is not exposed (i.e not defined on the interface CompiledConstraintSystem)

Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was getting late for me. I followed through where SetSchema was defined and it seems safe.

Base automatically changed from ccs-issolved-api to develop January 12, 2022 20:10
@gbotrel gbotrel merged commit 78d8162 into develop Jan 12, 2022
@gbotrel gbotrel deleted the ccs-schema branch January 12, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants