-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pod level metrics are not being surfaced #821
Comments
@utam0k do you have any insights on the cgroups path here? |
My insights are:
First of all, I'd like to know the cgroup path passed youki. |
I'm interested in this, can I give it a try? By the way, I thought that the cgroup paths should probably be modified as follows, but am I doing something wrong? A:
For pods that do not have runtimeClassName set, it looks like this: pod level: |
Sure, please go ahead and give it a try! Let me know what questions do you have. |
Of course, I can help you to investigate it! |
Apparently the issue is related to the cgroup driver. Currently using cgroupfs as cgroup driver.
However, the cgroup path It seems like there is a contradiction here. Let's try running K3s with
I could see pod level metrics. Next, try building with
This looks like the behavior we want. Based on this, what changes should I make? Any advice? Finally, thanks to @utam0k and my co-worker @sat0ken for their help. |
This is a duplicate of this issue found in the Spin shim: spinframework/containerd-shim-spin#180. I wanted to recreate it here as it is reproducable with the Wasmtime shim and may have to do with how cgroups are being created by Youki.
TLDR: Pod level metrics are not being found by kubelet (even though container level metrics exist).
Repro:
Cleanup:
Based on the above, i think we need to amend the container cgroup paths from A to B:
A: /sys/fs/cgroup//kubepods-besteffort-podb7c2cbdb_9ab5_47ef_977e_97e39a73da6d.slice:cri-containerd:66dda1e97c4fc48204b066f07fc1e28bab94a571820484e01576982d4cb9d32b
B: /sys/fs/cgroup/kubepods.slice/kubepods-besteffort.slice/kubepods-besteffort-podb7c2cbdb_9ab5_47ef_977e_97e39a73da6d.slice
I am not sure how to communicate this to Youki or modify this in Youki
The text was updated successfully, but these errors were encountered: