Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests are no longer run in github actions #452

Open
cfergeau opened this issue Jan 9, 2025 · 0 comments
Open

Unit tests are no longer run in github actions #452

cfergeau opened this issue Jan 9, 2025 · 0 comments
Assignees

Comments

@cfergeau
Copy link
Collaborator

cfergeau commented Jan 9, 2025

b525dc8#r1909010646

test-linux is not running as many tests as what test was running, go test ./... was running all of these:

pkg/services/dns/dns_test.go
pkg/services/dns/hosts_file_test.go
pkg/tap/ip_pool_test.go
test-win-sshproxy/basic_test.go
test-win-sshproxy/suite_test.go
test/basic_test.go
test/efi_darwin_arm64_test.go
test/port_forwarding_test.go
test/suite_test.go

Imo we can keep a test target which runs go test ./... but add build tags to the vfkit tests so that they are only run on macos and/or use the -skip parameter together with go test ./... to have more control over what is being run.

@lstocchi lstocchi self-assigned this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants