Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play remote system tests do not test proper failure in unsupported cases #16271

Closed
ygalblum opened this issue Oct 24, 2022 · 6 comments
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug. kube

Comments

@ygalblum
Copy link
Contributor

/kind bug

Description
Some features, e.g. podman play --build, are only supported locally and therefore block the user from using them with podman-remote. However, the system tests skip the relevant tests instead of verifying that the requests properly fail (see https://github.com/containers/podman/blob/main/test/system/700-play.bats#L243)

Steps to reproduce the issue:
Run the system test: PODMAN=./bin/podman-remote bats test/system/700-play.bats

Describe the results you received:
The test "podman play --build --context-dir" is skipped

Describe the results you expected:
The test verifies that the request was properly blockes

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 24, 2022
@vrothberg
Copy link
Member

Thanks for filing the issue, @ygalblum !

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Jul 29, 2023

@ygalblum @vrothberg Is the goal here to fix the tests or implement podman kube play --build for the remote API?

@vrothberg
Copy link
Member

I don't think that supporting --build on remote clients is worth the effort. At least for now where nobody has asked to support it.

So making sure the tests do proper error checks for remote clients SGTM

@vrothberg
Copy link
Member

Still a TODO

@Luap99
Copy link
Member

Luap99 commented Nov 1, 2024

There is some demand to add remote build support #24435
so this here can be closed I would say

@Luap99 Luap99 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kube
Projects
None yet
Development

No branches or pull requests

4 participants