Ensure that we don't add balancees with no health check runs if there is a health check defined on it #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jangie
force-pushed
the
only-add-marathon-balancees-if-any-healthcheck-results
branch
2 times, most recently
from
a86e667 to
b5b89ee
Compare
… is a health check defined on it Change test behavior
jangie
force-pushed
the
only-add-marathon-balancees-if-any-healthcheck-results
branch
from
b5b89ee to
ad12a72
Compare
emilevauge
approved these changes
Feb 3, 2017
ldez
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have been running into Traefik balancing against marathon balancees on container startup where the container is not yet ready to serve traffic.
As of the current behavior, the marathon provider will allow balancing to:
This PR aims to ensure that items which have health checks have at least one passing health check result prior to allowing them to be balanced against, removing the last category.