Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nicolas Mengin to maintainers #1792

Merged
merged 2 commits into from
Jun 27, 2017
Merged

Add Nicolas Mengin to maintainers #1792

merged 2 commits into from
Jun 27, 2017

Conversation

emilevauge
Copy link
Member

Description

This PR adds @nmengin to the maintainer team.

giphy

nmengin
nmengin approved these changes Jun 27, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vote-04

SantoDE
SantoDE approved these changes Jun 27, 2017
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

Welcome! 🍻

vdemeester
vdemeester approved these changes Jun 27, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🕶

juliens
juliens approved these changes Jun 27, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez
ldez approved these changes Jun 27, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the emilevauge-add-nmengin-maintainers branch from e2ca90a to 2ec8760 Compare June 27, 2017 13:15
dtomcej
dtomcej approved these changes Jun 27, 2017
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase, but other than that,

LGTM

:shipit:

errm
errm approved these changes Jun 27, 2017
View reviewed changes
Copy link
Contributor

@errm errm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez modified the milestone: 1.4 Jun 27, 2017
@ldez ldez force-pushed the emilevauge-add-nmengin-maintainers branch from 2ec8760 to a5201db Compare June 27, 2017 19:43
@ldez ldez merged commit 2201dcd into master Jun 27, 2017
@ldez ldez deleted the emilevauge-add-nmengin-maintainers branch June 27, 2017 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@nmengin nmengin nmengin approved these changes

@ldez ldez ldez approved these changes

@SantoDE SantoDE SantoDE approved these changes

@timoreimann timoreimann timoreimann approved these changes

@juliens juliens juliens approved these changes

@errm errm errm approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
area/documentation kind/enhancement a new or improved feature.
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
9 participants
@emilevauge @vdemeester @errm @juliens @timoreimann @SantoDE @ldez @nmengin @dtomcej