Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log X-Forwarded-For as ClientHost if present #1946

Merged
merged 4 commits into from
Aug 25, 2017
Merged

log X-Forwarded-For as ClientHost if present #1946

merged 4 commits into from
Aug 25, 2017

Conversation

mildis
Copy link
Contributor

@mildis mildis commented Aug 11, 2017

Log X-Forwarded-For value as ClientHost, if present.
Allow access log to display the correct caller behind a reverse proxy.

@emilevauge
Copy link
Member

@mildis Thanks for your contribution!
@rjshep as the author of this part, LGTY ?

@m3co-code
Copy link
Contributor

For me this change makes sense. AFAIK this is what is usually required from applications that sit behind a proxy and Traefik could also sit behind another proxy :D

@ldez ldez added this to the 1.4 milestone Aug 25, 2017
ldez
ldez approved these changes Aug 25, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Aug 25, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 92fb86b into traefik:master Aug 25, 2017
@Jancis
Copy link

Jancis commented May 28, 2020

I don't think this checks the forwardedHeaders.trustedIPs and so the access log can be filled with forged addresses.

@mildis mildis deleted the log_XFF branch May 28, 2020 12:00
@Jancis Jancis mentioned this pull request May 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@emilevauge emilevauge emilevauge approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/logs kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
7 participants
@mildis @emilevauge @m3co-code @Jancis @ldez @nmengin @traefiker