Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECS provider refactoring #2050

Merged
merged 4 commits into from
Sep 6, 2017
Merged

ECS provider refactoring #2050

merged 4 commits into from
Sep 6, 2017

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Sep 4, 2017

Description

Small refactoring of ECS provider and improve tests

@ldez ldez modified the milestone: 1.5 Sep 4, 2017
ldez
ldez approved these changes Sep 4, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Sep 5, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Sep 6, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 9ce4f94 into traefik:master Sep 6, 2017
@mmatur mmatur mentioned this pull request Sep 7, 2017
Merged
@oldmantaiter oldmantaiter mentioned this pull request Oct 24, 2017
Merged
@oldmantaiter oldmantaiter mentioned this pull request Oct 24, 2017
Merged
@mmatur mmatur deleted the refacto/ecs branch October 25, 2017 04:41
oldmantaiter added a commit to oldmantaiter/traefik that referenced this pull request Oct 25, 2017
@oldmantaiter
Add missing functions for ECS template
4c59c6e 
- Some functions were missing, this adds them to the function
  map passed into the template loader
- Adds testing around generating ECS configuration
- This regression was added in traefik#2050
@ldez ldez added the kind/enhancement a new or improved feature. label Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@ldez ldez ldez approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/ecs kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@mmatur @juliens @ldez @nmengin @traefiker