Rancher host IP address #2101
Merged
Rancher host IP address #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
status/2-needs-review
kind/bug/fix
|
Thanks for your contribution 👍 Could you change the base branch of this PR from Is there an already open issue about this problem? |
|
Sure thing @ldez. No. Should I make an issue for it? |
|
No need to open a new issue. It's not related to #1498 ? |
|
Oh right. I forgot about that. That's the one! :) |
|
Could you rebase your PR on the git rebase upstream/v1.4with: git remote -v
origin [email protected]:matq007/traefik.git (fetch)
origin [email protected]:matq007/traefik.git (push)
upstream [email protected]:containous/traefik.git (fetch)
upstream [email protected]:containous/traefik.git (push) |
ldez
force-pushed
the
fix-rancher-host
branch
from
de195e8 to
11db033
Compare
nmengin
requested changes
Sep 12, 2017
provider/rancher/api.go
Outdated
| rancher "github.com/rancher/go-rancher/client" | ||
| ) | ||
|
|
||
| const labelRancheStackServiceName = "io.rancher.stack_service.name" | ||
| const hostNetwork = "host" |
There was a problem hiding this comment.
Can you use a const block?
There was a problem hiding this comment.
Sure thing, on it right now :)
There was a problem hiding this comment.
Could you please rebase it again to 1.4 branch?
ldez
force-pushed
the
fix-rancher-host
branch
from
b3ce213 to
c506e2e
Compare
|
@matq007 please do: git checkout master
git branch -D fix-rancher-host
git checkout origin fix-rancher-host |
traefiker
force-pushed
the
fix-rancher-host
branch
from
c506e2e to
4570eea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Until now traefik was setting up
PrimaryIpAddresswhich is only set for managed network. When host network is chosen, traefik has to setup the IP address of the host machine where the container is running. As shown on the picture belowghot-1is on host network andghotis on managed network.Fixes #1498