Bump Lego Version for GoDaddy DNS Provider #2482
Conversation
build.Dockerfile
Outdated
| @@ -24,7 +24,7 @@ RUN mkdir -p /usr/local/bin \ | |||
|
|
|||
| # Download docker | |||
| RUN mkdir -p /usr/local/bin \ | |||
| && curl -fL https://download.docker.com/linux/static/stable/x86_64/docker-${DOCKER_VERSION}-ce.tgz \ | |||
| && curl -fL https://download.docker.com/linux/static/stable/x86_64/docker-${DOCKER_VERSION}.tgz \ | |||
There was a problem hiding this comment.
When I built the traefik-dev image from build.Dockerfile, I noticed the DOCKER_VERSION environment variable was set to 17.09.0-ce. Maybe Docker changed this recently? Anyway, the build wouldn't complete because it kept trying to download docker-17.09.0-ce-ce.tgz, which doesn't work so well.
glide.lock
Outdated
| @@ -544,7 +544,7 @@ imports: | |||
| - plugin/rewrite | |||
| - router | |||
| - name: github.com/xenolf/lego | |||
| version: 67c86d860a797ce2483f50d9174d4ed24984bef2 | |||
| version: aa94fb4696349fd6f35168dabe3ab030ddf3e484 | |||
There was a problem hiding this comment.
This right here and the GoDaddy DNS provider on line 561 are all I really want to change. Any help accomplishing that would be much appreciated. I'm very much a noob at gliding.
nmengin
added
area/acme
kind/enhancement
|
@sjawhar Thanks for your interest in Traefik 😃 I will fix your PR. |
|
@ldez Thanks for the assist! So I can be more helpful in the future, what's the right way to update glide.yaml and .lock as minimally as you did? |
What does this PR do?
The intention is just to bump the version of lego up to aa94fb46, to add support for the GoDaddy DNS provider. But glide and I don't seem to get along very well. It seems to just want to update ALL THE THINGS. I tried just running
but I'm told "lego is already in glide.yaml, dummy!"
I've seen that some of you have made very small changes to glide.yaml successfully, and I'd love to know how I can do it too!
Motivation
Now that that go-acme/lego#416 has been merged, it would be great it the version of lego could be bumped here in traefik so I don't have to keep making custom builds :)