Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new options to the CLI entrypoint definition. #2799

Merged
merged 4 commits into from
Feb 8, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Feb 3, 2018

What does this PR do?

Add missing option in entrypoint CLI parser:

  • auth.*
  • redirect.permanent

Motivation

Easy CLI configuration.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

The documentation will be updated when #2798 is merged.

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review labels Feb 3, 2018
@ldez ldez added this to the 1.6 milestone Feb 3, 2018
@ldez ldez force-pushed the feature/cli-entrypoint branch 2 times, most recently from e04572c to 41b965c Compare February 3, 2018 13:23
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the feature/cli-entrypoint branch from 41b965c to bc019f3 Compare February 6, 2018 15:58
@ldez ldez force-pushed the feature/cli-entrypoint branch from bc019f3 to e7f4ad3 Compare February 7, 2018 15:46
@ldez ldez removed the bot/no-merge label Feb 7, 2018
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 👏

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 6a92ac0 into traefik:master Feb 8, 2018
@ldez ldez deleted the feature/cli-entrypoint branch February 8, 2018 09:27
@ldez ldez mentioned this pull request Aug 1, 2018
@YtvwlD

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants