-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade AWS SKD to version v1.13.1 #2908
Conversation
@@ -740,7 +742,7 @@ | |||
[[projects]] | |||
name = "github.com/jmespath/go-jmespath" | |||
packages = ["."] | |||
revision = "bd40a432e4c76585ef6b72d3fd96fb9b6dc7b68d" | |||
revision = "0b12d6b5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it's come from here https://github.com/aws/aws-sdk-go/blob/22de44e02e1bc81533f39df20dce75d5ddb446dd/Gopkg.lock#L13
provider/ecs/ecs.go
Outdated
@@ -219,8 +222,8 @@ func (p *Provider) listInstances(ctx context.Context, client *awsClient) ([]ecsI | |||
break | |||
} | |||
} | |||
for _, carns := range clustersArn { | |||
clusters = append(clusters, *carns) | |||
for _, cArns := range clustersArn { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just cArn
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2b600c2
to
81701da
Compare
What does this PR do?
This PR upgrade AWS SDK to version v1.13.1
Motivation
Have last bug fixes of the SDK