Minor updates to dumpcerts.sh #3116
Conversation
ldez
added
status/2-needs-review
area/acme
kind/bug/fix
There was a problem hiding this comment.
Hello @mathuin .
Many thanks for the PR.
As I said in the issue #3115, the script has been changed to allow extracting files in new format.
That's why the modifications you made about it cannot be merged.
About the $1, I was aware about the problem and the correction is a part of Pull Request I am currently working on.
However, I do not know when this PR will be ready and I guess it's better to use your fix.
WDYT about rebasing your branch on the v1.6 and keep only the $1 correction?
|
I have checked the |
|
Hello @mathuin , It should be great if you can do it 😃 |
|
I pulled the most recent changes for |
|
Yeah, that did not go as I expected. I'm sorry -- if it doesn't work, perhaps it's better to wait for your fix. |
traefiker
force-pushed
the
fix-issue-3115
branch
from
1cad4ac to
2bd13ce
Compare
Closes #3115.
There was an extraneous $1 on line 69 which threw an error. The locations of keys and certificates in the JSON file have changed.
What does this PR do?
This pull request modifies
dumpcerts.shto run without errors and to access keys and certs in the JSON file correctly.Motivation
I now use Traefik to manage my LetsEncrypt certs for my mail server, so I needed to learn how to extract the certs and keys as files.
More
Additional Notes
I'm very new to Traefik. All I can say about this script is "it works for me". If it does not work for the general case, I would love to get some feedback to make a proper solution that works for both me and everyone else. Thank you in advance for your patience!