Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error pages and header merge #3394

Merged
merged 3 commits into from
May 28, 2018
Merged

Error pages and header merge #3394

merged 3 commits into from
May 28, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented May 26, 2018 •
edited
Loading

What does this PR do?

Don't copy backend response headers.

The problem occurs if the error page has streamed the content.

Motivation

Fixes #3338

Additional Notes

To reproduce:

  • call to backend: return an error and a header Content-Length
  • call to error page: return the page but without Content-Length (stream content)
  • write the final response: merge header from backend and error page
  • result the Content-Length is invalid.

@traefiker traefiker added this to the 1.6 milestone May 26, 2018
@dtomcej
Copy link
Contributor

dtomcej commented May 26, 2018

Is Content-Length the only header that should be dropped? if so, it will get a LGTM from me :)

@ldez ldez force-pushed the fix/error-pages branch from 77bae95 to ffb9b2f Compare May 28, 2018 11:30
nmengin
nmengin approved these changes May 28, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes May 28, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes May 28, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit fb5aa4c into traefik:v1.6 May 28, 2018
@traefiker traefiker mentioned this pull request May 28, 2018
Closed
@ldez ldez deleted the fix/error-pages branch May 28, 2018 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/middleware kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
6 participants
@ldez @dtomcej @juliens @mmatur @nmengin @traefiker