Allow multiple rules #435
Merged
Allow multiple rules #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ``` | ||
|
|
||
| - Three frontends are defined: `frontend1`, `frontend2` and `frontend3` | ||
| - `frontend1` will forward the traffic to the `backend2` if the rule `Host: test.localhost, test2.localhost` is matched | ||
| - `frontend2` will forward the traffic to the `backend1` if the rule `Host: localhost, {subdomain:[a-z]+}.localhost` is matched (forwarding client `Host` header to the backend) | ||
| - `frontend3` will forward the traffic to the `backend2` if the rule `Path:/test` is matched | ||
| - `frontend3` will forward the traffic to the `backend2` if the rule `Host: test3.localhost; Path:/test` is matched |
There was a problem hiding this comment.
if the rule
Host: test3.localhost; Path:/testis matched
I would prefer: if the rules Host: test3.localhost and Path:/testare matched ;)
|
One minor comment ;) Fixes #419 |
|
@emilevauge documentation OK |
|
LGTM 🐮 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow to set more than one route in labels/tags (#419)