Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env. WATCHTOWER_NOTIFICATION_EMAIL_SUBJECTTAG isn't working anymore since 1.4.0 #1205

Closed
MilesTEG1 opened this issue Jan 25, 2022 · 16 comments · Fixed by #1219
Closed

env. WATCHTOWER_NOTIFICATION_EMAIL_SUBJECTTAG isn't working anymore since 1.4.0 #1205

MilesTEG1 opened this issue Jan 25, 2022 · 16 comments · Fixed by #1219
Assignees

Comments

@MilesTEG1
Copy link

Describe the bug
Since the update to 1.4.0, the environment variable WATCHTOWER_NOTIFICATION_EMAIL_SUBJECTTAG isn't working.
In my docker-compose.yml file, I set this : - WATCHTOWER_NOTIFICATION_EMAIL_SUBJECTTAG=[ Watchtower-DS920+ ]
But all email I received has this subject:
Watchtower updates on 5d11f1abc714
image

Before the update, I got :
image

To Reproduce

Expected behavior
It should be with the subject I declare in the env variables, like this not too old email:
image

Screenshots
See previous...

Environment

  • Platform = Synology NAS DS920+
  • Architecture = amd64 (CPU = Intel Celeron J4125)
  • Docker version = 20.10.3, build b455053

I use Portainer CE 2.11 to create my container

Logs from running watchtower with the --debug option I'm not sure how to do the --debug option... But here what I have: ```log time="2022-01-25T09:56:09+01:00" level=debug time="2022-01-25T09:56:09+01:00" level=debug msg="Sleeping for a second to ensure the docker api client has been properly initialized." time="2022-01-25T09:56:10+01:00" level=debug msg="Making sure everything is sane before starting" time="2022-01-25T09:56:10+01:00" level=debug msg="Retrieving running containers" time="2022-01-25T09:56:10+01:00" level=debug msg="There are no additional watchtower containers" time="2022-01-25T09:56:10+01:00" level=debug msg="Watchtower HTTP API skipped." time="2022-01-25T09:56:10+01:00" level=info msg="Watchtower 1.4.0" time="2022-01-25T09:56:10+01:00" level=info msg="Using notifications: smtp" time="2022-01-25T09:56:10+01:00" level=info msg="Only checking containers using enable label" time="2022-01-25T09:56:10+01:00" level=info msg="Scheduling first run: 2022-01-26 05:00:00 +0100 CET" time="2022-01-25T09:56:10+01:00" level=info msg="Note that the first check will be performed in 19 hours, 3 minutes, 49 seconds" ```

Additional context

@bodycount28
Copy link

+1.

I too noticed this and have the same problem since the upgrade.

@sashaoshurkov
Copy link

+1
Looking forward to fixes please :)

@piksel piksel self-assigned this Jan 27, 2022
@dgkovachev
Copy link

same here...

@a-gerhard
Copy link

+1

@danielmbrown603
Copy link

+1

1 similar comment
@ijaron
Copy link

ijaron commented Feb 2, 2022

+1

@dgkovachev
Copy link

+100 this feature is very much needed when you have more than 5 servers. Hope this can be resolved shortly!

@nilava
Copy link

nilava commented Feb 26, 2022

+1

@jan-di
Copy link

jan-di commented Mar 3, 2022

Please don't write +1 comments, add your thumb up on the opening post. Otherwise you send an notification email to everyone that follows this issue..

As a workaround I changed the hostname of the container. The email header results in "Watchtower updates on ", which is not perfect but make the email distinguishable. CHanging the hostname of the watchtower container shouldn't have side effects.

@dgkovachev
Copy link

I personally went with the WATCHTOWER_NOTIFICATIONS_HOSTNAME=xyz variable witch achieves the same result as described above. Hope this helps...

@dvuckovic
Copy link

Note that in order to even consider WATCHTOWER_NOTIFICATIONS_HOSTNAME value, WATCHTOWER_NOTIFICATION_EMAIL_SUBJECTTAG must not be set in the first place.

@EDIflyer
Copy link
Contributor

EDIflyer commented Jul 12, 2022

This still doesn't seem to work for me? I tried the original WATCHTOWER_NOTIFICATION_EMAIL_SUBJECTTAG as per the documentation but no luck, then tried WATCHTOWER_TITLE_TAG as per #1270 above but neither seemed to do anything. I then set WATCHTOWER_NOTIFICATIONS_HOSTNAME instead and that worked OK, although is a different feature (but at least proves changing the environment settings was doing something!)

@piksel
Copy link
Member

piksel commented Jul 12, 2022

@EDIflyer It's merged but not released in stable. You can test it in containrrr/watchtower:latest-dev.

@EDIflyer
Copy link
Contributor

Ahh OK, sorry hadn't spotted it hadn't made it to stable yet 😄 👍

@EDIflyer
Copy link
Contributor

@piksel just to confirm now tried :latest-dev and confirm WATCHTOWER_NOTIFICATION_TITLE_TAG and WATCHTOWER_NOTIFICATION_EMAIL_SUBJECTTAG both worked as alternative options along with WATCHTOWER_NOTIFICATIONS_HOSTNAME as a combined option 👍 🎉

@BeyondVertical
Copy link

I have the same problem and wanted to ask when it is released to the stable branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.