feat: Verify job ownership #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the Renovate CronJob shares its namespace with other resources, we need to ensure that any jobs we return are actually related to the Renovate CronJob and not part of something else. In the case of scheduled jobs, this is easily verified using the job's owner references. In the case of jobs triggered manually via Foreman, it appears we need to introduce a custom label by which we can then filter (which is what this patch does). When testing this patch, non-related jobs no longer show up in Foreman while scheduled and manual jobs still do.
lusu007
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the Renovate CronJob shares its namespace with other resources, we need to ensure that any jobs we return are actually related to the Renovate CronJob and not part of something else.
In the case of scheduled jobs, this is easily verified using the job's owner references. In the case of jobs triggered manually via Foreman, it appears we need to introduce a custom label by which we can then filter (which is what this patch does).
When testing this patch, non-related jobs no longer show up in Foreman while scheduled and manual jobs still do.