Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend from just one config (string) #864

Closed
onrige opened this issue Nov 21, 2019 · 4 comments
Closed

Extend from just one config (string) #864

onrige opened this issue Nov 21, 2019 · 4 comments

Comments

@onrige
Copy link
Contributor

onrige commented Nov 21, 2019

Hey. Just a question. Can we add possibility to extend from single string not just from array? So it will work like other linting libraries (eslint, stylelint, etc.).

package.json

"babel":  {
  "extends": "shared-tools"
},
"commitlint": {
  "extends": [
    "shared-tools"
  ]
},
"eslintConfig": {
  "extends": "shared-tools"
}
@escapedcat
Copy link
Member

Not sure if I can follow. Your suggestion in opposite to what? Can you write down the array example?

If this is about adding a config via package.json this can already be done, i.e.: https://commitlint.js.org/#/reference-examples

@onrige
Copy link
Contributor Author

onrige commented Nov 21, 2019

I mean we must provide array of configs and can't provide just one.

Any commitlint config on project now. For example package.json.

"commitlint": {
  "extends": [
    "my-config"
  ]
}

We can't provide just string as we can in any other linting library.

"commitlint": {
  "extends": "my-config"
}

@escapedcat
Copy link
Member

Uhm, got it, thanks for explanation!

@escapedcat
Copy link
Member

MR was merged. Forgot to close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants