-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore 'vaadin-split-layout' #83
Comments
@anoblet post a sneak peek screenshot or a short screencap? |
@lkraav I'm writing it in Typescript as that is what I'm familiar with. Trying to resolve two issues with one PR :) Storybook/Typescript/Babel is proving to be a little bit difficult though. |
My original idea was to try to refactor But it may be hard to grasp all the details there, we could do a introductory screenshare session. I just pushed a RC to https://github.com/conversionxl/aybolit/tree/leho-cxl-app-layout definitely rebase to this. |
I intend on bringing in the site specific content (header, navigation, main, footer) soon. My intent is to isolate the functionality of I'm open to a screen share session :) |
Yes, but this creates a relatively large re-implementation of everything 1-column. Instead, you could patch cxl-app-layout's current template to use vaadin-split-layout, instead of fully custom drawer build, maybe drop most "2c" css, and start from that point. You'd have a significant head start towards meeting end result expectations. |
The current iteration relies on |
I updated the branch to be refactored based on cxl-app-layout. Looks like a lot of it works apart from some styling of the side bar. Screen capture can be seen here: https://youtu.be/9TQxl7LYo44 |
Work can be seen here: https://github.com/anoblet/aybolit/tree/vaadin-split-layout
The text was updated successfully, but these errors were encountered: