Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline Live stream Twitch permanent loading state #643

Closed
luiscerqueira opened this issue May 10, 2019 · 2 comments
Closed

Offline Live stream Twitch permanent loading state #643

luiscerqueira opened this issue May 10, 2019 · 2 comments

Comments

@luiscerqueira
Copy link
Contributor

Current Behavior

After passing an offline twitch stream url as a prop, the player will not switch/update to any other twitch video/stream url passed after it.

Expected Behavior

After passing an offline twitch stream url, it should be possible to play any other twitch video/stream url passed in the props.

Steps to Reproduce

  1. Go to the demo page #Demo
  2. Select Twitch Test B video
  3. Select Twitch Test C stream
  4. Select Twitch Test B video again

Step 3 forward, every url we pass to the component, the player will not change because he is stuck in an infinite loading state

Environment

  • URL attempting to play:
  • Browser: Opera/Chrome/Firefox
  • Operating system: Windows 10

Other informations

The Player only throw the onEnded event for the offline live stream.
Warning ReactPlayer: the attempt to load https://www.twitch.tv/videos/12783852 is being deferred until the player has loaded is appearing in the browser console

@luiscerqueira
Copy link
Contributor Author

@cookpete

I made a pull request (#657) with an implementation for this issue.
Would you please be able to take a look?

@cookpete
Copy link
Owner

Fixed in #657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants