Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: System Wide GitHub Apps does not work #2643

Closed
iamEvanYT opened this issue Jun 23, 2024 · 6 comments · Fixed by #4598
Closed

[Bug]: System Wide GitHub Apps does not work #2643

iamEvanYT opened this issue Jun 23, 2024 · 6 comments · Fixed by #4598

Comments

@iamEvanYT
Copy link
Contributor

iamEvanYT commented Jun 23, 2024

Description

image
After I set the GitHub app to system wide, it does not appear on my other teams.

Minimal Reproduction (if possible, example repository)

  1. Create a GitHub App
  2. Enable the System Wide option
  3. Go to another team
  4. It does not show in other teams.

Exception or Error

Looking into the code, this function should be where the bug is.

coolify/app/Models/Team.php

Lines 188 to 196 in de7380f

public function sources()
{
$sources = collect([]);
$github_apps = $this->hasMany(GithubApp::class)->whereisPublic(false)->get();
$gitlab_apps = $this->hasMany(GitlabApp::class)->whereisPublic(false)->get();
$sources = $sources->merge($github_apps)->merge($gitlab_apps);
return $sources;
}

Version

v4.0.0-beta.297

@ari-party
Copy link
Contributor

Reproduced it on v4.0.0-beta.315

@andrasbacsai andrasbacsai added 🐛 Bug Reported issues that need to be reproduced by the team. 🚧 Next Issues and PRs planned for the next release. labels Jul 18, 2024
@iamEvanYT
Copy link
Contributor Author

@andrasbacsai any updates?

@sandros94
Copy link

Also on v4.0.0-beta.329

@iamEvanYT
Copy link
Contributor Author

Hey @peaklabs-dev, can you take a look at this issue?

@peaklabs-dev peaklabs-dev removed the 🚧 Next Issues and PRs planned for the next release. label Nov 22, 2024
@peaklabs-dev peaklabs-dev added 🐞 Confirmed Bug Verified issues that have been reproduced by the team. and removed 🐛 Bug Reported issues that need to be reproduced by the team. labels Dec 4, 2024
@peaklabs-dev peaklabs-dev added this to the v4.0.0 Stable Release milestone Dec 4, 2024
@aahnik
Copy link

aahnik commented Jan 12, 2025

I am facing the same issue, would love to see any updates on this. Eager to contribute towards the fix, via any documentation, or testing, as I am not familiar with php.

@peaklabs-dev peaklabs-dev self-assigned this Jan 13, 2025
@peaklabs-dev peaklabs-dev added the 🚧 Next Issues and PRs planned for the next release. label Jan 13, 2025
@peaklabs-dev
Copy link
Member

A fix for this issue has been implemented and will be available in an upcoming release. Thank you for your patience.

@github-actions github-actions bot removed 🚧 Next Issues and PRs planned for the next release. 🐞 Confirmed Bug Verified issues that have been reproduced by the team. labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants