Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Clone skips domains and proxy config #4073

Closed
theDanielJLewis opened this issue Oct 30, 2024 · 2 comments · Fixed by #4598
Closed

[Bug]: Clone skips domains and proxy config #4073

theDanielJLewis opened this issue Oct 30, 2024 · 2 comments · Fixed by #4598

Comments

@theDanielJLewis
Copy link

Error Message and Logs

No error, but obvious omissions in end results.

Steps to Reproduce

  1. Create a site using a git repo
  2. Customize the domain(s)
  3. Customize the proxy (Traefik or Caddy) container labels and checkmark "Readonly labels"
  4. Clone the site (to anywhere)
  5. Observe that neither the domains nor the proxy config were cloned

Example Repository URL

No response

Coolify Version

v4.0.0-beta360

Are you using Coolify Cloud?

No (self-hosted)

Operating System and Version (self-hosted)

Ubuntu 22.04

Additional Information

I can understand not cloning domains, although it would still be very useful to do so. This would make migrations or working with staging projects easier.

But ignoring the proxy container labels is really frustrating.

@theDanielJLewis theDanielJLewis added 🐛 Bug Reported issues that need to be reproduced by the team. 🔍 Triage Issues that need assessment and prioritization. labels Oct 30, 2024
@peaklabs-dev peaklabs-dev self-assigned this Jan 7, 2025
@peaklabs-dev peaklabs-dev removed the 🔍 Triage Issues that need assessment and prioritization. label Jan 7, 2025
@peaklabs-dev
Copy link
Member

peaklabs-dev commented Jan 9, 2025

I have implemented a fix for this issue and it will be available in an upcoming release. Thanks for your patience.

It now auto-generates a new domain and proxy labels only if read-only is checked, if it is unchecked it will copy your labels and domain over like you manually set it up.

@peaklabs-dev peaklabs-dev added this to the v4.0.0 Stable Release milestone Jan 9, 2025
@theDanielJLewis
Copy link
Author

Thank you!

@github-actions github-actions bot removed the 🐛 Bug Reported issues that need to be reproduced by the team. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants