Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sonata\AdminBundle\Admin\AdminExtension", extended by "CoopTilleuls\Bundle\AclSonataAdminExtensionBundle\Admin\AclAdminExtension", deprecated in "sonata-project/admin-bundle": "3.x-dev" with Symfony 3.3.10 #27

Closed
olivsinz opened this issue Dec 26, 2017 · 4 comments

Comments

@olivsinz
Copy link

olivsinz commented Dec 26, 2017

The "CoopTilleuls\Bundle\AclSonataAdminExtensionBundle\Admin\AclAdminExtension" class extends "Sonata\AdminBundle\Admin\AdminExtension" that is deprecated since version 3.1, to be removed in 4.0. Use Sonata\AdminBundle\AbstractAdminExtension instead

capture d ecran de 2017-12-26 15-08-25

@olivsinz olivsinz changed the title The "CoopTilleuls\Bundle\AclSonataAdminExtensionBundle\Admin\AclAdminExtension" class extends "Sonata\AdminBundle\Admin\AdminExtension" that is deprecated since version 3.1, to be removed in 4.0. Use Sonata\AdminBundle\AbstractAdminExtension instead "Sonata\AdminBundle\Admin\AdminExtension", extended by "CoopTilleuls\Bundle\AclSonataAdminExtensionBundle\Admin\AclAdminExtension", deprecated in "sonata-project/admin-bundle": "3.x-dev" with Symfony 3.3.10 Dec 26, 2017
@dunglas
Copy link
Member

dunglas commented Dec 26, 2017

It needs an update. Would you mind opening a Pull Request?

As we want to support both 3.x and 4.x, you'll probably need to conditionally define the inherited class like this:

if (class_exists(AbstractAdminExtension::class)) {
    abstract class InternalAbstractClass extends AbstractAdminExtension {}
} else {
    abstract class InternalAbstractClass extends AdminExtension {}
}

class AclAdminExtension extends InternalAbstractClass
{
  // ...
}

@olivsinz
Copy link
Author

Ok I am working on it

@dunglas
Copy link
Member

dunglas commented Dec 26, 2017

Thanks!

@olivsinz
Copy link
Author

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants