Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow: Increment version number using matching board type and pcb version #181

Open
matias-cphatomics opened this issue Nov 13, 2024 · 0 comments

Comments

@matias-cphatomics
Copy link
Contributor

matias-cphatomics commented Nov 13, 2024

As of now the mono-release-on-push action increments the version number of releases based on board type only.

This mostly works as intended e.g. if a new release is pushed to BoardA of PCB V1.1 with current release version 2.0.0 (BoardA-2.0.0-PCBv1.1) then the next release correctly becomes BoardA-2.1.0-PCBv1.1

However, if a patch is released for BoardA for a previous PCB version e.g. PCB V1.0 whose latest sw version was 1.0.0, then the mono-release-on-push will still increment the version number to BoardA-2.0.1-PCBv1.0 instead of BoardA-1.0.1-PCBv1.0 because it does not take the PCB version into account.

Unfortunately, the PCB version is not part of the tag of the release so there may be a need to do some search in the workflow prior to calling the mono-release-on-push action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant