fix(invalidated stack): GPU rendering - inheriting voiRange when recr…

…eating the default actor (#598) * bugfix - GPU rendering - inheriting voiRange when recreating the default actor * use "stackInvalidated" flag instead * change test truth image
cornerstonejs · May 5, 2023 · 457746a · 457746a
1 parent 94f2776
commit 457746a
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 30 deletions.
diff --git a/packages/core/src/RenderingEngine/StackViewport.ts b/packages/core/src/RenderingEngine/StackViewport.ts
@@ -1222,7 +1222,8 @@ class StackViewport extends Viewport implements IStackViewport {
       this.voiRange &&
       this.voiRange.lower === voiRange.lower &&
       this.voiRange.upper === voiRange.upper &&
-      !forceRecreateLUTFunction
+      !forceRecreateLUTFunction &&
+      !this.stackInvalidated
     ) {
       return;
     }

diff --git a/packages/core/test/groundTruth/calibrated_1_5_imageURI_11_11_4_1_1_1_0_1.png b/packages/core/test/groundTruth/calibrated_1_5_imageURI_11_11_4_1_1_1_0_1.png
diff --git a/packages/core/test/stackViewport_gpu_render_test.js b/packages/core/test/stackViewport_gpu_render_test.js
@@ -814,35 +814,6 @@ describe('renderingCore -- Stack', () => {
         done.fail(e);
       }
     });
-  });
-
-  describe('Calibration ', () => {
-    beforeEach(function () {
-      cache.purgeCache();
-      this.DOMElements = [];
-
-      this.renderingEngine = new RenderingEngine(renderingEngineId);
-      imageLoader.registerImageLoader('fakeImageLoader', fakeImageLoader);
-      metaData.addProvider(fakeMetaDataProvider, 10000);
-      metaData.addProvider(
-        calibratedPixelSpacingMetadataProvider.get.bind(
-          calibratedPixelSpacingMetadataProvider
-        ),
-        11000
-      );
-    });
-
-    afterEach(function () {
-      cache.purgeCache();
-      this.renderingEngine.destroy();
-      metaData.removeProvider(fakeMetaDataProvider);
-      imageLoader.unregisterAllImageLoaders();
-      this.DOMElements.forEach((el) => {
-        if (el.parentNode) {
-          el.parentNode.removeChild(el);
-        }
-      });
-    });
 
     it('Should be able to fire imageCalibrated event with expected data', function (done) {
       const element = createViewport(this.renderingEngine, AXIAL, 256, 256);