feat: remove unnecessary event firing for annotations #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swederik
reviewed
Jun 8, 2022
JamesAPetts
approved these changes
Jun 8, 2022
JamesAPetts
requested changes
Jun 10, 2022
| // half of the height of the viewport in the world unit (mm), we can use that | ||
| // to compute the scale factor which is the ratio of the viewport height in pixels | ||
| // to the current rendered image height. | ||
| const { rowPixelSpacing } = image; |
There was a problem hiding this comment.
Ooooh, what if the viewport is rotated? I don't think it correct.
|
|
||
| viewport.scale += diff; // parallelScale; //viewport.scale < 0.1 ? 0.1 : viewport.scale; | ||
| if (scale) { | ||
| const { rowPixelSpacing } = image; |
|
|
||
| import _getHash from './_getHash'; | ||
|
|
||
| import _setAttributesIfNecessary from './_setAttributesIfNecessary'; | ||
| import _setNewAttributesIfValid from './_setNewAttributesIfValid'; | ||
|
|
||
| function drawCircle( | ||
| svgDrawingHelper: any, | ||
| svgDrawingHelper: SVGDrawingHelper, |
There was a problem hiding this comment.
I thought we settled on svgDraingHelpers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
Feat:
suppressEventsto StackViewportsetProperties