-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Cornerstone Tools more extensible #186
Comments
It would also help with customizing text box. Which lines we want to show, have them translated to user language etc. Right now I don't think there even is option to not have it shown. |
I need to use |
maybe we can export them? |
I'm going to try a fork for now. We have more tools we need to develop and I'm curious as to what's possible with the full power of cs3d. |
@ahlaughland I'm in the process of wrapping up cornerstone3D. Can you maybe create a PR to our beta branch? |
Explained by use-case
I was trying to make a small customization of the EllipticalROI tool.
So I started with extending the existing EllipticalROITool class. (NOTE: I was using Typescript)
The problem was, I wasn't able to call
renderAnnotation()
method of the original tool class from the new class and therefore I had to copy the full code of therenderAnnotation()
method to the new class. And this was followed by some hacks to import internal functions/constants that are not publicly exported from tools package.Possible cause and solution?
I think it is because the
renderAnnotation()
method is defined in the form ofrenderAnnotation = () => {}
.And to be able to call this function from child classes, it'd better be defined in the form of
renderAnnotation() {}
Necessity ?
This will help us to extend the existing tool without fully redefining the methods.
Particularly useful when we want to add small changes to the existing tools like additional annotations.
The text was updated successfully, but these errors were encountered: