Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: draw center point of the ellipticalROI tool and make it configurable #191

Merged
merged 6 commits into from
Aug 30, 2022
Merged

feat: draw center point of the ellipticalROI tool and make it configurable #191

merged 6 commits into from
Aug 30, 2022

Conversation

md-prog
Copy link
Contributor

@md-prog md-prog commented Aug 26, 2022

No description provided.

@netlify
Copy link

netlify bot commented Aug 26, 2022 •
edited
Loading

✅ Deploy Preview for cornerstone-3d-docs canceled.

Name Link
🔨 Latest commit b6e3ca4
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/630e5a725b0f11000946569c

md-prog added 2 commits August 26, 2022 16:46
@md-prog
cornerstonejs#190 - moved utility function : getCanvasEllipseCenter()…
7a06262 
… to internal, as it changes public api of cornerstone-tools and not quite sure of its usuability in other tools, yet
@md-prog
cornerstonejs#190 - removed separate getCanvasEllipseCenter()
17fb399
@sedghi
Copy link
Member

sedghi commented Aug 26, 2022

You need to run the yarn build:update-api and include the generated markdown files.
Also can you post here a screenshot of what it looks like?

@md-prog
Copy link
Contributor Author

md-prog commented Aug 26, 2022

You need to run the yarn build:update-api and include the generated markdown files. Also can you post here a screenshot of what it looks like?

Thank you, it did the trick.

@md-prog
Copy link
Contributor Author

md-prog commented Aug 26, 2022

@sedghi Please review

@sedghi
Copy link
Member

sedghi commented Aug 30, 2022

Can you put a screenshot of the annotation while the config is set to true?

1 similar comment
@sedghi
Copy link
Member

sedghi commented Aug 30, 2022

Can you put a screenshot of the annotation while the config is set to true?

@md-prog
Copy link
Contributor Author

md-prog commented Aug 30, 2022 •
edited
Loading

Sure. Here it is.
image

The size of the center point can be configured.

sedghi
sedghi requested changes Aug 30, 2022
View reviewed changes
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments

@sedghi sedghi changed the title #190 - draw center point of the ellipticalROI tool and make it configurable feat: draw center point of the ellipticalROI tool and make it configurable Aug 30, 2022
@md-prog
Copy link
Contributor Author

md-prog commented Aug 30, 2022

Please see comments

Fixed as per your review

@sedghi sedghi merged commit b0ad00c into cornerstonejs:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sedghi sedghi sedghi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@md-prog @sedghi