Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Example/rtss #202

Closed
wants to merge 4 commits into from
Closed

[WIP]: Example/rtss #202

wants to merge 4 commits into from

Conversation

dxlin
Copy link
Contributor

@dxlin dxlin commented Sep 6, 2022

WIP - segmentToRTSS example has function for converting segmentation volume to ROIContour to be sent to dcmjs for export. Conversion to contour is performed via vtkImageMarchingSquares routine on each of the slices.

  1. Currently missing Referenced Image UIDs, should this be populated instead in dcmjs?
  2. Would the conversion function be best placed in a tool or as a general util?

@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit a890377
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6317f9b03d87c500090e72b3
😎 Deploy Preview https://deploy-preview-202--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sedghi sedghi changed the title Example/rtss [WIP]: Example/rtss Sep 6, 2022
@sedghi
Copy link
Member

sedghi commented Sep 6, 2022

Hey, glad to see that you have some progress on this. One small note, you need to add the name of the example folder here for it to show up in the demo page.

Looking forward to try it

@dxlin
Copy link
Contributor Author

dxlin commented Sep 7, 2022

Thanks for notice! I've updated with the changes.

The example at the moment only outputs the contour object in the console. The intention is for this object to be passed to dcmjs for export.

@sedghi
Copy link
Member

sedghi commented Sep 7, 2022

@dxlin Cornerstone3D does not have dependency on dcmjs (and we don't want to add that), hmmm, I'm wondering if then PR to Cornerstone is a bad idea. Let's try to implement the non-dcmjs part of the functionalities in the tools, and then the demo itself can have dependency on the dcmjs (right now some of them does).

@sedghi
Copy link
Member

sedghi commented Oct 14, 2023

Done in another PR #734

@sedghi sedghi closed this Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants