fix(voi) : wrong voiRange for some multi-frame instances or multi-instance series rendered on the same viewport #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at are rendered on the reused viewport but new actor
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sedghi
changed the title
sedghi
approved these changes
Oct 7, 2022
wayfarer3130
pushed a commit
that referenced
this pull request
Jan 20, 2023
* fix: 🐛 IDC Re #2003: fix regression in parsing segmentation orietations * fix: 🐛 fix array format regression from commit 70b24332783d63c9db2ed21d512d9f7b526c5222 * fix: 🐛 force a release for commit caaac4bead91f34dd393208a7b47180923c915b4 * fix: 🐛 force a release for commit caaac4bead91f34dd393208a7b47180923c915b4 * fix: 🐛 tolerance parameter was not propagated * fix var description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On GPU Rendering mode:
When we try to render a new image on the reused viewport, but this line: https://github.com/cornerstonejs/cornerstone3D-beta/blob/6ffaee7e817843c3971502d9ec32d85716a1de15/packages/core/src/RenderingEngine/StackViewport.ts#L1648 results in false value, it will create a new rendering actor. and when it does this, and if the newly rendered image doesn't have specific VOI Range values are set, the voiRange correction won't happen, resulting in bad window level and center - on UI side it will appear as white noises.
This will possibly fix the #225