Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resetCamera and annotations for flipped viewports #278

Merged
merged 7 commits into from
Nov 4, 2022

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Nov 3, 2022

  • resetViewport was broken after the new flip implementation
  • tool rendering were broken since we were filtering based on the orientation which is not logical with the new flip via camera API

Verified

This commit was signed with the committer’s verified signature.
dtolnay David Tolnay

Verified

This commit was signed with the committer’s verified signature.
dtolnay David Tolnay

Verified

This commit was signed with the committer’s verified signature.
dtolnay David Tolnay

Verified

This commit was signed with the committer’s verified signature.
dtolnay David Tolnay
@netlify
Copy link

netlify bot commented Nov 3, 2022

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 32a9170
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/63645b32ae732b000975134f
😎 Deploy Preview https://deploy-preview-278--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sedghi sedghi requested a review from swederik November 3, 2022 23:01

Verified

This commit was signed with the committer’s verified signature.
dtolnay David Tolnay
@sedghi sedghi changed the title Fix/flip remaining fixes fix: resetCamera and annotations for flipped viewports Nov 4, 2022
@sedghi sedghi merged commit cabefce into main Nov 4, 2022
NeilMacPhee pushed a commit to NeilMacPhee/cornerstone3D-beta that referenced this pull request Nov 10, 2022
…#278)

* fix: remove applyTx since flip is not on actor anymore

* fix: make annotations appear on flipeed viewports

* fix: reset camera for flipped viewports

* fix build

* fix test

* fix: tests

* fix build
NeilMacPhee pushed a commit to NeilMacPhee/cornerstone3D-beta that referenced this pull request Nov 22, 2022
…#278)

* fix: remove applyTx since flip is not on actor anymore

* fix: make annotations appear on flipeed viewports

* fix: reset camera for flipped viewports

* fix build

* fix test

* fix: tests

* fix build
wayfarer3130 pushed a commit that referenced this pull request Jan 20, 2023
… of to zero (#278)

This is needed when doing C-FIND with dcmjs-dimse, where "" needs to mean 'match everything', and not be converted to zero.
@sedghi sedghi deleted the fix/flip-remaining-fixes branch January 22, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants