Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create namespace for imageLoader and volumeLoader #3

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

swederik
Copy link
Member

remove getVolume from top level export

rename setVolumesOnViewports and addVolumesOnViewports

rename Utilities to utilities

add Enums top level export to cornerstone-render

remaining work for Enums for cornerstone render

rename Cursors to cursors

add annotation name space for annotations

add segmentation name space for all seg methods

rename setUseCPURender

remove error codes and put it in events

renamed enums to PascalCase

rename all cap enums to PascalCase

made orientation as CONSTANT

make cpu colormaps a CONSTANT

wip for creating enums for csTools

rename cornerstoneToolsEvents to Events

move BlendModes to Cornerstone core

move getVolumeViewportsContainingSameVolumes to utilities

change annotation style to annotation config

add documentation to cs-image-volume-streaming-loader

change createNewSegmentationForViewport to for ToolGroup

redo segmentation screenshots with the correct colorLUT

rebuild yarn lock

Verified

This commit was signed with the committer’s verified signature.
guggero Oliver Gugger
remove getVolume from top level export

rename setVolumesOnViewports and addVolumesOnViewports

rename Utilities to utilities

add Enums top level export to cornerstone-render

remaining work for Enums for cornerstone render

rename Cursors to cursors

add annotation name space for annotations

add segmentation name space for all seg methods

rename setUseCPURender

remove error codes and put it in events

renamed enums to PascalCase

rename all cap enums to PascalCase

made orientation as CONSTANT

make cpu colormaps a CONSTANT

wip for creating enums for csTools

rename cornerstoneToolsEvents to Events

move BlendModes to Cornerstone core

move getVolumeViewportsContainingSameVolumes to utilities

change annotation style to annotation config

add documentation to cs-image-volume-streaming-loader

change createNewSegmentationForViewport to for ToolGroup

redo segmentation screenshots with the correct colorLUT

rebuild yarn lock
@swederik swederik force-pushed the docs/exports-manual branch from 61c09e5 to ca7d1a9 Compare March 22, 2022 09:57
@swederik swederik merged commit b591735 into main Mar 22, 2022
@swederik swederik deleted the docs/exports-manual branch March 22, 2022 10:07
sedghi pushed a commit that referenced this pull request Jan 27, 2023
* feat: added touch to view tools and annotation tools

Native touch is now enabled for view tools (pan/scroll/zoom/magnify/etc)
and annotations tools (length, rect, ellipse, freehandroi, etc)

Touch events consist of
 - TOUCH_START
 - TOUCH_START_ACTIVATE
 - TOUCH_PRESS
 - TOUCH_DRAG
 - TOUCH_END
 - TOUCH_TAP
 - TOUCH_SWIPE

All touch are multi touch supported. In order to be easily compatible with
mouse tools, multi touch are "reduced" by taking the mean of touch points.
Other reduction strategies are possible such as first value, and future work
may consider making these reduction strategies configurable.

Touch drag calculates pinch by calculating the average change in distance among
multi touch. Rotation is possible by translating points by the mean, matching
touch identifiers (which are consistent if a user adds/removes fingers), and
calculating the theta relative to the mean point. Each points theta could be
averaged to get a final rotation.

Touch event dispatcher checks for activeTool when looking for handles / overlay
annotations on a touch start. This is because there is no "touch move" event
which highlights handles. Proximity is also increased for the case of a touch
interaction.

Touch events also provide a force/radius parameter. Future work can provide
these as binding options

Touch based segmentation is not yet implemented.

* fix(touch):Make the touch events fire correctly for primary

Touch events weren't listening to key modifiers and button primary

* fix(htj2k):Support htj2k in the streaming volume loader

* fix import

* Update for PR

* Event Types refactored. NormalizedMouseEventDetail and NormalizedTouchEventDetail merged into NormalizedInteractionEventDetail

* Solving Rebase

* Gradienthealth/change types (#3)

* Event Types refactored. NormalizedMouseEventDetail and NormalizedTouchEventDetail merged into NormalizedInteractionEventDetail

* Types changed

* Types updated

* Refactored

* InteractionEventType included

* Event types refactored

* deleted as with main

* Solving conflicts

* Fix setToolActive logic

* Normalize InteractionEventType for tools

* Update changes

* Docs Updated

* Docs Updated

* Build conflicts solved

* API Updated

* Tools changes

* Listeners changed

* Event changed

* Listeners Reorganized

* postTouchDownCallback function fixed

* postTouchStartCallback function fixed

* added documentation and minor nit

* docs: added todo and example

* removed import

---------
Co-authored-by: Diego Hennrich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants