fix(conversion):World to image throws an exception on outside image #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
wayfarer3130
commented
Nov 17, 2022
| imageCoords[1] >= rows | ||
| checkCoordinateSpace && | ||
| (imageCoords[0] < 0 || | ||
| imageCoords[0] > columns || |
There was a problem hiding this comment.
The image coordinates have to be strictly larger than columns,rows as the last pixel is columns-1...columns inclusive.
wayfarer3130
commented
Nov 17, 2022
| imageCoords[0] >= columns || | ||
| imageCoords[1] < 0 || | ||
| imageCoords[1] >= rows | ||
| checkCoordinateSpace && |
There was a problem hiding this comment.
Only check coordinates if requested to do so - normally that isn't a useful thing to do inside the method, as there are quite a few cases where at least one coordinate can usefully be outside by nearby the image.
|
Hmmm, looking at it again, I guess it shouldn't throw an error at all. Maybe we just remove that check fully? |
wayfarer3130
force-pushed
the
fix/worldToImage-exception
branch
from
79174d8 to
3f48962
Compare
wayfarer3130
force-pushed
the
fix/worldToImage-exception
branch
from
3f48962 to
e4c1768
Compare
sedghi
approved these changes
Nov 18, 2022
NeilMacPhee
pushed a commit
to NeilMacPhee/cornerstone3D-beta
that referenced
this pull request
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are lots of cases where world to image should allow producing coordinates outside the image. Make the exception optional.