Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multiframe example #331

Merged
merged 8 commits into from
Jan 16, 2023

Conversation

rodrigobasilio2022
Copy link
Contributor

  • Add support to multiframe dicom images to cornerstone
  • Add a new function convertMultiframeImageIds that expands a multiframe imageid to a list of imageids where each imageid corresponds to a frame, the imageid ending with frames/x, where x corresponds to the number of the frame .i.e
    an imageid /studies/StudyInstanceUID/series/SeriesInstanceUID/instances/SOPInstanceUID/frames/1 will be converted to

/studies/StudyInstanceUID/series/SeriesInstanceUID/instances/SOPInstanceUID/frames/1
/studies/StudyInstanceUID/series/SeriesInstanceUID/instances/SOPInstanceUID/frames/2
...
/studies/StudyInstanceUID/series/SeriesInstanceUID/instances/SOPInstanceUID/frames/n

@netlify
Copy link

netlify bot commented Dec 9, 2022

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 554b061
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/63c5b289e36a3e0008a028ad
😎 Deploy Preview https://deploy-preview-331--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sedghi sedghi changed the title Feat/multiframe feat: add multiframe example to render Jan 16, 2023
@sedghi sedghi changed the title feat: add multiframe example to render feat: add multiframe example Jan 16, 2023
@sedghi sedghi merged commit 327f17a into cornerstonejs:main Jan 16, 2023
@ssokmen
Copy link
Contributor

ssokmen commented Jan 17, 2023

Hello, did you check the https://www.cornerstonejs.org/live-examples/ after the merge process?
some examples doesn't work properly

image

@sedghi
Copy link
Member

sedghi commented Jan 17, 2023

@ssokmen for some reason our ci webpack didn't catch that. We will fix it

rodrigobasilio2022 added a commit to RadicalImaging/basilioCornerstone3D that referenced this pull request Jan 21, 2023
* First commit

* Add multiframe support to cs3d

* Remove unnecessary file and refactoring

* Remove unnecessary file and refactoring code

* Running required checks

* Refactoring convertMultiframeImageIds function

* Adding multiframe support for local example

* Update cswil version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants