fix: AngleTool not working after cancellation #342
Conversation
AngleTool will be broken after annotation cancellation, because it tries to get the annotationId of a non-existing annotation. Fixed this issue by setting angleStartedNotYetCompleted to false upon cancellation.
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -462,6 +462,7 @@ class AngleTool extends AnnotationTool { | |||
| } | |||
|
|
|||
| this.editData = null; | |||
| this.angleStartedNotYetCompleted = false; | |||
There was a problem hiding this comment.
I don't see how this line only is solving the bug you found, maybe not all your source changes are pushed?
There was a problem hiding this comment.
I only meant to change this single line.
Basically, after calling the cancel event, the user should be able to click on another point in the viewport to start annotating an angle, calling the addNewAnnotation method. In line 99 of this script, the tool checks if there are some unfinished angles:
if (this.angleStartedNotYetCompleted) {
return;
}This check prevents adding new annotations as this.angleStartedNotYetCompleted is set to true after the drawing starts (line 103). So, we have to set it to false in the cancel method to allow for new annotations to be created after that.
|
Thanks for your contribution |
sedghi
changed the title
AngleTool will be broken after annotation cancellation, because it tries to get the
annotationIdof a non-existing annotation.Fixed this issue by setting
angleStartedNotYetCompletedto false upon cancellation.