feat(contour api): add api for contour rendering configuration #443
Conversation
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I ran into an out of memory problem once for the contourrendering example. However, I have not seen it since... |
| }); | ||
|
|
||
| addSliderToToolbar({ | ||
| title: 'Change Segment 2 Thickness For left viewport', |
There was a problem hiding this comment.
JSYK... I tried the new example, but I found that the slider cannot be dragged all the way to the right. Is this expected?
sedghi
force-pushed
the
feat/remaining-rtss
branch
from
9bdb148 to
7021051
Compare
packages/tools/src/tools/displayTools/Contour/addOrUpdateContourSets.ts
Outdated
Show resolved
Hide resolved
packages/tools/src/tools/displayTools/Contour/contourConfigCache.ts
Outdated
Show resolved
Hide resolved
| @@ -123,17 +117,10 @@ function removeSegmentationRepresentation( | |||
| */ | |||
| async function render( | |||
| viewport: Types.IVolumeViewport, | |||
| representation: ToolGroupSpecificRepresentation, | |||
| representationConfig: ToolGroupSpecificRepresentation, | |||
There was a problem hiding this comment.
Why was this renamed to config?
There was a problem hiding this comment.
it is was named incorrectly before
|
|
||
| const newOutlineWithActive = newContourConfig.outlineWidthActive; | ||
|
|
||
| if (cachedConfig.outlineWidthActive !== newOutlineWithActive) { |
There was a problem hiding this comment.
Is there a chance that cachedConfig might be undefined or null?
There was a problem hiding this comment.
there shouldn't be since we add first, and that caches it, but I added the checks
| const type = contour.getType(); | ||
|
|
||
| // creating a point index list that defines a line | ||
| const pointIndexes = pointList.map((_, i) => i + pointIndex); |
There was a problem hiding this comment.
Consider renaming i to pointListIndex or something.
sedghi
changed the title
LabelmapvsContoursegmentation representationvisibility(for all its contour sets), and per contour set:visibilityandthickness