fix(voi): stack viewport should prioritize image metadata for windowlevel and not persist #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
wayfarer3130
reviewed
Mar 2, 2023
sedghi
changed the title
wayfarer3130
reviewed
Mar 2, 2023
wayfarer3130
reviewed
Mar 2, 2023
sedghi
commented
Mar 3, 2023
| @@ -2636,6 +2584,95 @@ class StackViewport extends Viewport implements IStackViewport { | |||
|
|
|||
| return newImagePlaneModule; | |||
| } | |||
|
|
|||
| private renderingPipelineFunctions = { | |||
sedghi
changed the title
wayfarer3130
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack viewport was not updating the
voiif the new image'svoiwas different. This PR willvoiRangeif it is in the metadatavoiis set via outside set (e.g.,setProperties) then thevoibecomes a global voi for the whole stackresetPropertieswill make it back to the per imagevoiGround truth Test images are changed since now the metadata has more priority
address OHIF/Viewers#3190