Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windowLevelTool): WWWL multipler too high when burned in pixels are present #462

Merged

Conversation

Ouwen
Copy link
Contributor

@Ouwen Ouwen commented Mar 5, 2023

Burned in Pixels often use pixel values above the BitsStored. This results in a multiplier which is way higher than what you would want in practice.

@netlify
Copy link

netlify bot commented Mar 5, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit c7229e5
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6406bb47c11a450008faffe9
😎 Deploy Preview https://deploy-preview-462--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put the same comment you put on the description in the code as well? thanks

@Ouwen Ouwen force-pushed the gradienthealth/fix_wwwl_multiplier branch from 7faeefe to c7229e5 Compare March 7, 2023 04:19
@Ouwen
Copy link
Contributor Author

Ouwen commented Mar 7, 2023

@sedghi added the inline comment ready for merge!

@sedghi sedghi changed the title fix: WWWL multipler too high when burned in pixels are present fix(windowLevelTool): WWWL multipler too high when burned in pixels are present Mar 7, 2023
@sedghi sedghi merged commit 47bfa46 into cornerstonejs:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants