Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation: duplicate event "annotation added"? #570

Closed
jlopes90 opened this issue Apr 19, 2023 · 1 comment
Closed

Annotation: duplicate event "annotation added"? #570

jlopes90 opened this issue Apr 19, 2023 · 1 comment

Comments

@jlopes90
Copy link
Contributor

jlopes90 commented Apr 19, 2023

When drawing annotation it fires "annotation added" event but then "triggerAnnotationAddedForFOR" means get all viewports and fire "annotation added" event again.

https://github.com/cornerstonejs/cornerstone3D-beta/blob/cc3ce18f1c601fc911d8866987ae369a8f4c28df/packages/tools/src/stateManagement/annotation/annotationState.ts#L87-L96

@jlopes90 jlopes90 changed the title duplicate event "annotation added"? Annotation: duplicate event "annotation added"? Apr 19, 2023
@iamiota
Copy link
Contributor

iamiota commented Apr 28, 2023

same +1, putting triggerAnnotationAddedForFOR in else can solve it.

iamiota added a commit to iamiota/cornerstone3D-beta that referenced this issue Apr 28, 2023

Verified

This commit was signed with the committer’s verified signature.
guggero Oliver Gugger
sedghi pushed a commit that referenced this issue Jul 4, 2023
…#633)

* fix triggering of 'ANNOTATION_ADDED' event multiple times (#570)

* Add configuration to fix the issue of inability to access device information files in the Internet from within the local network(LAN).

* add gpuTier and getGPUTierConfig to Cornerstone3DConfig

* add gpuTier and getGPUTierConfig to Cornerstone3DConfig

* update gpuTier and detectGPUConfig document

* update api

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants