fix: renderToCanvas to use CPU rendering #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sedghi
commented
Apr 12, 2022
sedghi
commented
- Fix the renderToCanvas to use the CPU rendering pipeline
- Add stackPrefetch utility function
JamesAPetts
approved these changes
Apr 13, 2022
| canvas: HTMLCanvasElement, | ||
| imageId: string, | ||
| requestType = RequestType.Interaction, | ||
| priority = -5 |
There was a problem hiding this comment.
Shall we just hardcode this as something super high priority? It feels like no one, not even power users, would ever specify anything other than now for this? Setting a priority so it loads in some queue you have no knowledge of when making this call feels realllly weird.
There was a problem hiding this comment.
I think it has some value to keep the parameters and give default options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.