-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: selection API, requestPoolManager and VOI and Scaling #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sedghi
commented
Apr 21, 2022
•
edited
Loading
edited
- change the selection api to not rely on the annotation object (UID is enough)
- add PRE_NEW_STACK_IMAGE event for consumers
- add a check for if the loaded image is prescaled (if it was loaded with the scaling parameters), if so it handles the PT non scaled images
- Fix the CPU rendering for PT images
- Add id to the pool managers
- Fix a bug in the requestPoolManager when a new image is added (interaction priority), it was waiting for a request to be finished before sending the high priority image request
- Fix a bug in requestPool to set the maximum number of requests based on the requestType, previously it was summing all up and comparing them with the current number of requests, it should be per requestType
- Fix prefetching imageIds requests to properly set the prefetch requestType
- Port over the orientation helpers from cornerstone-tools
sedghi
changed the title
fix: selection API, requestPoolManager and Scaling
fix: selection API, requestPoolManager and VOI and Scaling
Apr 21, 2022
JamesAPetts
requested changes
Apr 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments.
packages/tools/src/utilities/orientation/getOrientationString.ts
Outdated
Show resolved
Hide resolved
JamesAPetts
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.