Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selection API, requestPoolManager and VOI and Scaling #82

Merged
merged 7 commits into from
Apr 21, 2022
Merged

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Apr 21, 2022

  • change the selection api to not rely on the annotation object (UID is enough)
  • add PRE_NEW_STACK_IMAGE event for consumers
  • add a check for if the loaded image is prescaled (if it was loaded with the scaling parameters), if so it handles the PT non scaled images
  • Fix the CPU rendering for PT images
  • Add id to the pool managers
  • Fix a bug in the requestPoolManager when a new image is added (interaction priority), it was waiting for a request to be finished before sending the high priority image request
  • Fix a bug in requestPool to set the maximum number of requests based on the requestType, previously it was summing all up and comparing them with the current number of requests, it should be per requestType
  • Fix prefetching imageIds requests to properly set the prefetch requestType
  • Port over the orientation helpers from cornerstone-tools

@sedghi sedghi requested a review from JamesAPetts April 21, 2022 02:51
@sedghi sedghi changed the title Fix/voi fix: selection API, requestPoolManager and Scaling Apr 21, 2022
@sedghi sedghi changed the title fix: selection API, requestPoolManager and Scaling fix: selection API, requestPoolManager and VOI and Scaling Apr 21, 2022
Copy link
Member

@JamesAPetts JamesAPetts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

@sedghi sedghi requested a review from JamesAPetts April 21, 2022 16:47
@sedghi sedghi merged commit bedd8dd into main Apr 21, 2022
@swederik swederik deleted the fix/voi branch July 8, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants